Add a test to assert that migrations are ordered as we declared them #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
force-pushed
the
chore/add-test-to-check-migration-order
branch
from
4416404 to
2bb0a9f
Compare
Codecov Report
@@ Coverage Diff @@
## master #467 +/- ##
=======================================
Coverage 35.82% 35.82%
=======================================
Files 47 47
Lines 2892 2892
=======================================
Hits 1036 1036
Misses 1763 1763
Partials 93 93 Continue to review full report at Codecov.
|
gauravgahlot
suggested changes
Mar 26, 2021
db/migration/migration_test.go
Outdated
| // | ||
| // https://github.com/rubenv/sql-migrate/blob/011dc47c6043b25483490739b61cabbc5da7ee9a/migrate.go#L216 | ||
| // | ||
| // In order to improve the visbility and to akwnoldge that the way we |
There was a problem hiding this comment.
Suggested change
| // In order to improve the visbility and to akwnoldge that the way we | |
| // In order to improve the visibility and to acknowledge that the way we |
db/migration/migration_test.go
Outdated
| // A possible solution is to write our own MigrationSet who won't do the | ||
| // ordering. In the meantime I (gianarb) will start a conversation with library | ||
| // maintainer to figure out how we can improve this. | ||
| func TestMigrationAreOrderendInTheWayWeDeclaredThem(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestMigrationAreOrderendInTheWayWeDeclaredThem(t *testing.T) { | |
| func TestMigrationsAreOrderendInTheWayWeDeclaredThem(t *testing.T) { |
db/migration/migration_test.go
Outdated
| t.Fatal(err) | ||
| } | ||
| if len(declaredMigration) != len(orderedMigration) { | ||
| t.Error("migrations have not the same number of elements. This should never happen.") |
There was a problem hiding this comment.
Suggested change
| t.Error("migrations have not the same number of elements. This should never happen.") | |
| t.Error("Migrations do not have the same number of elements. This should never happen.") |
gianarb
force-pushed
the
chore/add-test-to-check-migration-order
branch
from
2bb0a9f to
8ec9ce1
Compare
This tests is coming from this PR #466 We didn't fully understood how the migration library sorts migration before having to troubleshoot that PR. Even if we declare them in order as part of the GetMigrations function the library still applies quick sort on the migration ID to stay concurrency safe https://github.com/rubenv/sql-migrate/blob/011dc47c6043b25483490739b61cabbc5da7ee9a/migrate.goL216 In order to improve the visbility and to akwnoldge that the way we append migrations to GetMigrations is the same we get after the sorting we wrote this tests. Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
force-pushed
the
chore/add-test-to-check-migration-order
branch
from
8ec9ce1 to
8face1a
Compare
gauravgahlot
approved these changes
Mar 26, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests is coming from this PR
#466
We didn't fully understood how the migration library sorts migration
before having to troubleshoot that PR. Even if we declare them in order
as part of the GetMigrations function the library still applies quick
sort on the migration ID to stay concurrency safe
https://github.com/rubenv/sql-migrate/blob/011dc47c6043b25483490739b61cabbc5da7ee9a/migrate.goL216
In order to improve the visbility and to akwnoldge that the way we
append migrations to GetMigrations is the same we get after the sorting
we wrote this tests.
I will start a conversation with the lib maintainer to figure out how we can improve our current workflow.